diff --git a/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h b/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h index a55a74be34c88..e1f63c458a4ea 100644 --- a/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h +++ b/DataFormats/Detectors/TPC/include/DataFormatsTPC/IDC.h @@ -85,7 +85,6 @@ struct Data { uint32_t getLinkValue(const uint32_t link) const { - const auto valPtr = dataWords; const uint32_t offset = link * IDCvalueBits; const uint32_t selectedWord = offset / 8; const uint32_t requiredShift = offset % 8; diff --git a/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h b/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h index 00b3d749a3833..e82eb52ae7769 100644 --- a/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h +++ b/DataFormats/Detectors/TPC/include/DataFormatsTPC/LaserTrack.h @@ -36,7 +36,7 @@ class LaserTrack : public o2::track::TrackPar static constexpr std::array CoarseBundleZPos{243.5, 165.5, 82, 11.5}; ///< coarse z-position of the laser bundles LaserTrack() = default; - LaserTrack(int id, float x, float alpha, const std::array& par) : mID(id), o2::track::TrackPar(x, alpha, par) { ; } + LaserTrack(int id, float x, float alpha, const std::array& par) : o2::track::TrackPar(x, alpha, par), mID(id) {} LaserTrack(LaserTrack const&) = default; /// set laser track ID diff --git a/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx b/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx index a1268c02a2740..eadd754316615 100644 --- a/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx +++ b/DataFormats/Detectors/TPC/src/ClusterNativeHelper.cxx @@ -63,7 +63,7 @@ std::unique_ptr ClusterNativeHelper::createClusterNativeInd { std::unique_ptr retVal(new ClusterNativeAccess); memset(retVal.get(), 0, sizeof(*retVal)); - for (int i = 0; i < clusters.size(); i++) { + for (size_t i = 0; i < clusters.size(); i++) { if (retVal->nClusters[clusters[i].sector][clusters[i].globalPadRow]) { LOG(error) << "Received two containers for the same sector / row"; return std::unique_ptr(); @@ -77,7 +77,7 @@ std::unique_ptr ClusterNativeHelper::createClusterNativeInd } retVal->clustersLinear = buffer.get(); retVal->setOffsetPtrs(); - for (int i = 0; i < clusters.size(); i++) { + for (size_t i = 0; i < clusters.size(); i++) { memcpy(&buffer[retVal->clusterOffset[clusters[i].sector][clusters[i].globalPadRow]], clusters[i].clusters.data(), sizeof(*retVal->clustersLinear) * clusters[i].clusters.size()); if (mcTruth) { for (unsigned int j = 0; j < clusters[i].clusters.size(); j++) { @@ -87,7 +87,7 @@ std::unique_ptr ClusterNativeHelper::createClusterNativeInd } } } - return (std::move(retVal)); + return retVal; } ClusterNativeHelper::Reader::~Reader() diff --git a/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h b/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h index 17078b5d3741b..af08a581993aa 100644 --- a/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h +++ b/Detectors/TPC/calibration/include/TPCCalibration/LaserTracksCalibrator.h @@ -24,7 +24,7 @@ namespace o2::tpc { -class LaserTracksCalibrator : public o2::calibration::TimeSlotCalibration +class LaserTracksCalibrator final : public o2::calibration::TimeSlotCalibration { using TFType = o2::calibration::TFType; using Slot = o2::calibration::TimeSlot;