From f38451eb44bcda2547d751296fcc89856eec4d99 Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 10:00:48 +0100 Subject: [PATCH 01/12] Updated to Stylelint 8.0.0 --- index.js | 16 ++++++++-------- package.json | 5 +++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/index.js b/index.js index 259aaec..0023dc7 100644 --- a/index.js +++ b/index.js @@ -1,4 +1,7 @@ module.exports = { + plugins: [ + "stylelint-order" + ], rules: { // Color 'color-hex-case': 'upper', @@ -52,11 +55,9 @@ module.exports = { 'declaration-bang-space-before': 'always', 'declaration-colon-space-after': null, 'declaration-colon-space-before': 'never', - // 'declaration-no-important': [true, {'severity': 'warning'}], // Declaration block 'declaration-block-no-duplicate-properties': true, - 'declaration-block-no-ignored-properties': [true, {'severity': 'warning'}], 'declaration-block-no-shorthand-property-overrides': true, 'declaration-block-semicolon-newline-after': 'always-multi-line', 'declaration-block-semicolon-newline-before': 'never-multi-line', @@ -64,7 +65,7 @@ module.exports = { 'declaration-block-semicolon-space-before': 'never', 'declaration-block-single-line-max-declarations': 1, 'declaration-block-trailing-semicolon': 'always', - 'declaration-block-properties-order': [ + 'order/properties-order': [ [ // Generated content 'content', @@ -209,7 +210,8 @@ module.exports = { 'block-closing-brace-space-after': 'always-single-line', 'block-closing-brace-space-before': 'always-single-line', 'block-no-empty': null, - 'block-no-single-line': true, + 'block-opening-brace-newline-after': ['always'], + 'block-closing-brace-newline-before': ['always'], 'block-opening-brace-newline-after': 'always-multi-line', 'block-opening-brace-newline-before': 'never-single-line', 'block-opening-brace-space-after': 'always-single-line', @@ -218,8 +220,8 @@ module.exports = { // Selector 'selector-combinator-space-after': 'always', 'selector-combinator-space-before': 'always', - // 'selector-no-id': [true, {'severity': 'warning'}], - 'selector-no-universal': true, + 'selector-max-id': 0, + 'selector-max-universal': 0, 'selector-no-vendor-prefix': [true, {'severity': 'warning'}], 'selector-pseudo-class-case': 'lower', 'selector-pseudo-class-no-unknown': true, @@ -239,7 +241,6 @@ module.exports = { 'media-feature-colon-space-after': 'always', 'media-feature-colon-space-before': 'never', 'media-feature-name-no-vendor-prefix': [true, {'severity': 'warning'}], - 'media-feature-no-missing-punctuation': true, 'media-feature-range-operator-space-after': 'always', 'media-feature-range-operator-space-before': 'always', 'media-feature-parentheses-space-inside': 'never', @@ -249,7 +250,6 @@ module.exports = { // General / Sheet 'max-empty-lines': 3, - // 'max-nesting-depth': [3, {'severity': 'warning'}], 'no-descending-specificity': null, 'no-eol-whitespace': true, 'no-invalid-double-slash-comments': true, diff --git a/package.json b/package.json index 19520aa..476f656 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "stylelint-config-wildbit", - "version": "1.1.0", + "version": "1.2.0", "description": "Shareable stylelint config", "main": "index.js", "repository": { @@ -18,6 +18,7 @@ }, "homepage": "https://github.com/wildbit/stylelint-config-wildbit#readme", "devDependencies": { - "stylelint": "^7.1.0" + "stylelint": "^8.0.0", + "stylelint-order": "^0.6.0" } } From fcd98ffed98c0247de7c405002e28d7e844e89b2 Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 10:09:42 +0100 Subject: [PATCH 02/12] Move stylelint any stylelint-order to regular dependencies. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 476f656..ec1c793 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "url": "https://github.com/wildbit/stylelint-config-wildbit/issues" }, "homepage": "https://github.com/wildbit/stylelint-config-wildbit#readme", - "devDependencies": { + "dependencies": { "stylelint": "^8.0.0", "stylelint-order": "^0.6.0" } From ca16e7acc91de6f62ffd407436ee5d1b0a7e5d1c Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 10:12:17 +0100 Subject: [PATCH 03/12] Removed max id rule. --- index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/index.js b/index.js index 0023dc7..4184e9e 100644 --- a/index.js +++ b/index.js @@ -220,7 +220,6 @@ module.exports = { // Selector 'selector-combinator-space-after': 'always', 'selector-combinator-space-before': 'always', - 'selector-max-id': 0, 'selector-max-universal': 0, 'selector-no-vendor-prefix': [true, {'severity': 'warning'}], 'selector-pseudo-class-case': 'lower', From 4dbd98b4a2d1324fac8df7962ec1ff068ff86598 Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 16:42:48 +0100 Subject: [PATCH 04/12] Fix stylelint dependency. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ec1c793..ec8e508 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ }, "homepage": "https://github.com/wildbit/stylelint-config-wildbit#readme", "dependencies": { - "stylelint": "^8.0.0", + "stylelint": "~8.0.0", "stylelint-order": "^0.6.0" } } From 226d7e1660a714a9f0a0d758122231b662c07bfc Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 16:53:26 +0100 Subject: [PATCH 05/12] Updated stylelint rules. --- index.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/index.js b/index.js index 4184e9e..5f9c129 100644 --- a/index.js +++ b/index.js @@ -11,6 +11,7 @@ module.exports = { // Font family 'font-family-name-quotes': 'always-where-recommended', + 'font-family-no-duplicate-names': true, // Function 'function-calc-no-unspaced-operator': true, @@ -59,6 +60,7 @@ module.exports = { // Declaration block 'declaration-block-no-duplicate-properties': true, 'declaration-block-no-shorthand-property-overrides': true, + 'declaration-block-no-redundant-longhand-properties': true, 'declaration-block-semicolon-newline-after': 'always-multi-line', 'declaration-block-semicolon-newline-before': 'never-multi-line', 'declaration-block-semicolon-space-after': 'always-single-line', @@ -229,6 +231,7 @@ module.exports = { 'selector-type-case': 'lower', 'selector-type-no-unknown': [true, {'severity': 'warning'}], 'selector-attribute-quotes': 'always', + 'selector-descendant-combinator-no-non-space': true, // Selector list 'selector-list-comma-newline-after': 'always', @@ -248,6 +251,7 @@ module.exports = { 'comment-whitespace-inside': 'always', // General / Sheet + 'indentation': 2, 'max-empty-lines': 3, 'no-descending-specificity': null, 'no-eol-whitespace': true, From 3ce674c1757d1bf8fefe35637b8e18a3d68d8711 Mon Sep 17 00:00:00 2001 From: Matt West Date: Tue, 25 Jul 2017 16:56:17 +0100 Subject: [PATCH 06/12] Removed indentation rule. --- index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/index.js b/index.js index 5f9c129..96ad98a 100644 --- a/index.js +++ b/index.js @@ -251,7 +251,6 @@ module.exports = { 'comment-whitespace-inside': 'always', // General / Sheet - 'indentation': 2, 'max-empty-lines': 3, 'no-descending-specificity': null, 'no-eol-whitespace': true, From e7283869e24bdf2b99c7d4c8e8c537ea5a3a8f01 Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 19:49:02 -0400 Subject: [PATCH 07/12] Removed duplicated properties --- index.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/index.js b/index.js index 96ad98a..a978964 100644 --- a/index.js +++ b/index.js @@ -212,8 +212,6 @@ module.exports = { 'block-closing-brace-space-after': 'always-single-line', 'block-closing-brace-space-before': 'always-single-line', 'block-no-empty': null, - 'block-opening-brace-newline-after': ['always'], - 'block-closing-brace-newline-before': ['always'], 'block-opening-brace-newline-after': 'always-multi-line', 'block-opening-brace-newline-before': 'never-single-line', 'block-opening-brace-space-after': 'always-single-line', From 01a8bd4b6d572f0c1bd00732f21d5883e2b67081 Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 19:49:33 -0400 Subject: [PATCH 08/12] Added new rules from Stylelint 7.1.0 --- index.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index a978964..cf8af45 100644 --- a/index.js +++ b/index.js @@ -207,15 +207,16 @@ module.exports = { ], // Block + 'block-closing-brace-empty-line-before': 'never', 'block-closing-brace-newline-after': 'always', 'block-closing-brace-newline-before': 'always-multi-line', 'block-closing-brace-space-after': 'always-single-line', 'block-closing-brace-space-before': 'always-single-line', - 'block-no-empty': null, 'block-opening-brace-newline-after': 'always-multi-line', 'block-opening-brace-newline-before': 'never-single-line', 'block-opening-brace-space-after': 'always-single-line', 'block-opening-brace-space-before': 'always', + 'block-no-empty': null, // Selector 'selector-combinator-space-after': 'always', @@ -240,12 +241,14 @@ module.exports = { // Media feature 'media-feature-colon-space-after': 'always', 'media-feature-colon-space-before': 'never', + 'media-feature-name-case': 'lower', 'media-feature-name-no-vendor-prefix': [true, {'severity': 'warning'}], 'media-feature-range-operator-space-after': 'always', 'media-feature-range-operator-space-before': 'always', 'media-feature-parentheses-space-inside': 'never', // Comment + 'comment-no-empty': true, 'comment-whitespace-inside': 'always', // General / Sheet From daaded0b768d96ee1be7166eef0b5f8c05f03a08 Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 19:54:25 -0400 Subject: [PATCH 09/12] Added new rules from Stylelint 7.2.0 --- index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/index.js b/index.js index cf8af45..14d344d 100644 --- a/index.js +++ b/index.js @@ -45,6 +45,7 @@ module.exports = { 'value-list-comma-newline-after': 'always-multi-line', 'value-list-comma-space-after': 'always-single-line', 'value-list-comma-space-before': 'never', + 'value-list-max-empty-lines': 0, // Property 'property-case': 'lower', @@ -242,6 +243,7 @@ module.exports = { 'media-feature-colon-space-after': 'always', 'media-feature-colon-space-before': 'never', 'media-feature-name-case': 'lower', + 'media-feature-name-no-unknown': true, 'media-feature-name-no-vendor-prefix': [true, {'severity': 'warning'}], 'media-feature-range-operator-space-after': 'always', 'media-feature-range-operator-space-before': 'always', From e8b13e54c216027e2e2dd03ee41a7796bc004712 Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 21:10:16 -0400 Subject: [PATCH 10/12] Bump Stylelint version to the latest one --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index ec8e508..0d00a66 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ }, "homepage": "https://github.com/wildbit/stylelint-config-wildbit#readme", "dependencies": { - "stylelint": "~8.0.0", + "stylelint": "~8.1.1", "stylelint-order": "^0.6.0" } } From 3f40b00b4afa0b9b91da79a5660ee58f40c96fcb Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 21:18:43 -0400 Subject: [PATCH 11/12] Keep declaration-block-no-redundant-longhand-properties as a warning --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 14d344d..4d41e44 100644 --- a/index.js +++ b/index.js @@ -61,7 +61,7 @@ module.exports = { // Declaration block 'declaration-block-no-duplicate-properties': true, 'declaration-block-no-shorthand-property-overrides': true, - 'declaration-block-no-redundant-longhand-properties': true, + 'declaration-block-no-redundant-longhand-properties': [true, {'severity': 'warning'}], 'declaration-block-semicolon-newline-after': 'always-multi-line', 'declaration-block-semicolon-newline-before': 'never-multi-line', 'declaration-block-semicolon-space-after': 'always-single-line', From 70fb8c6f114b9cd67a126e3b51e5a5d84d013634 Mon Sep 17 00:00:00 2001 From: Eugene Fedorenko Date: Sat, 16 Sep 2017 21:43:23 -0400 Subject: [PATCH 12/12] =?UTF-8?q?Updated=20module=E2=80=99s=20version?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0d00a66..8b1ae6d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "stylelint-config-wildbit", - "version": "1.2.0", + "version": "8.1.1", "description": "Shareable stylelint config", "main": "index.js", "repository": {