Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the the wildfly-galleon-pack content and feature pack build into separate maven modules #505

Open
bstansberry opened this issue Nov 25, 2023 · 2 comments
Labels

Comments

@bstansberry
Copy link
Contributor

Allow for easy use of the wildfly-galleon-pack content in feature packs other than one based on wildfly-ee by separating the content and the feature pack build.

The content is applicable to a f-p that depends on any WildFly Core based feature pack, including wildfly-core fp itself as well as wildfly-preview. Make it easy for those to create f-ps. The primary use case for those kinds of fps is to run tests of prospero integration into installations created from wildfly-core or wildfly-preview. Particular wildfly-core, which is in a separate project which is the appropriate place to test integration of prospero into the WF kernel.

@spyrkob
Copy link
Collaborator

spyrkob commented Nov 27, 2023

@bstansberry when you say content do you mean something like https://github.com/wildfly-extras/prospero/tree/main/dist/common/src/main + https://github.com/wildfly-extras/prospero/tree/main/dist/wildfly-galleon-pack/src/main/resources/modules? And to distribute it as a zip archive that can be used by other projects?

@bstansberry
Copy link
Contributor Author

@spyrkob Combining the 'common' stuff into the zip would be a nice-to-have.

And TBH it might be enough to just deploy a -src artifact for the wildfly-galleon-pack module. At least for the short term.

As I've done more work on the stuff that led me to file this, it seems less urgent to me. Adding a FP based on this on top of wildfly-core FP doesn't really work as the jackson deps are not present. And making them present seems like overkill.

Adding it on top of wildfly-preview has more value, but it's more in the nice-to-have area.

It might be good to just let this sit for now and see if some better requirements come out of work we're doing.

@spyrkob spyrkob added the hold label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants