Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving artifacts when using versions in feature pack is very slow #584

Open
spyrkob opened this issue Mar 6, 2024 · 2 comments
Open
Labels
enhancement Enhancement of existing feature ready Issue can be worked on

Comments

@spyrkob
Copy link
Collaborator

spyrkob commented Mar 6, 2024

When the manifest doesn't contain all artifact versions, the fallback is resolving each missing artifact separately. This results in a very slow download.

Handiling of the missing artifacts needs to be changes to batch resolve all missing artifacts.

The way ChannelMavenArtifactRepositoryManager#resolveAll handles missing streams is by intercepting NoStreamFoundException thrown channelSession.resolveMavenArtifacts. However this exception contains only a single artifact at a time.

One solution would be changing wildfly-channels ChannelSession implementation to aggregate all failed artifacts into one exception.

@spyrkob spyrkob added enhancement Enhancement of existing feature ready Issue can be worked on labels Apr 8, 2024
@parsharma
Copy link
Contributor

@spyrkob are you working on this?

@spyrkob
Copy link
Collaborator Author

spyrkob commented Aug 8, 2024

@parsharma no I'm not you can take it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature ready Issue can be worked on
Projects
None yet
Development

No branches or pull requests

2 participants