[WFCORE-5279] Split Elytron SSL into its own subsystem and layer #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicarod7
force-pushed
the
WFCORE-5279
branch
3 times, most recently
from
c813e2d
to
198a620
Compare
jessicarod7
force-pushed
the
WFCORE-5279
branch
3 times, most recently
from
6791bf8
to
4b42740
Compare
jessicarod7
force-pushed
the
WFCORE-5279
branch
3 times, most recently
from
ed3f2ce
to
76fc1dc
Compare
Temporarily disabled key/trust manager objects for SSLContext, key store objects for key/trust managers. Acts the same as references.
Project successfully builds as-is
…new service builders
Started to convert most components to use Service, as opposed to deprecated Service<T> and InjectedValue<T>
jessicarod7
force-pushed
the
WFCORE-5279
branch
from
864b25e
to
f7b100e
Compare
- Removed unneeded artifacts for feature packs - Added missing dependencies for WildflyAcmeClient - Created new feature group with full Elytron for early testing - Removed redundant elytron-tls-base feature group
…apability references
Skyllarr
reviewed
Sep 1, 2022
...main/resources/modules/system/layers/base/org/wildfly/elytron-tls-dependency/main/module.xml
Outdated
Show resolved
Hide resolved
.../main/resources/modules/system/layers/base/org/wildfly/extension/elytron-tls/main/module.xml
Outdated
Show resolved
Hide resolved
Skyllarr
reviewed
Sep 1, 2022
.../main/resources/modules/system/layers/base/org/wildfly/extension/elytron-tls/main/module.xml
Outdated
Show resolved
Hide resolved
Using ServiceValueExecutorRegistry from wildfly-clustering
Subsystem will implement its own version of combined ServiceValueExecutor and OperationExecutor
As planned, will use a common RuntimeServiceObject to store both values from service Consumers, and service instances (when extended)
jessicarod7
force-pushed
the
WFCORE-5279
branch
from
279c2c2
to
4a3b0cf
Compare
Need to review if inherited classes of RuntimeServiceFunction is a better solution for runtime injection. May just end up removing FunctionSupplier altogether.
Renamed to RuntimeServiceMethods, which is extended by each Service
|
Removing this PR since the changes needed to implement the new Service API are rather extensive and undoing the changes directly is unfeasible. Will open a new PR for WFCORE-5279 using the legacy Service API. This branch and its changes was renamed to new-service-template and might be used later on as method to implement the new API. Relevant files are:
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC for elytron-tls-subsystem. Will derive from changes in ELY-2084 branch of
wildfly-elytron. Continuing from #1.Related issues: