Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2620] Add a test that makes use of the RoleMapper#and method to RoleMappingTest #1998

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[ELY-2620] Add a test that makes use of the RoleMapper#and method to RoleMappingTest #1998

merged 1 commit into from
Oct 10, 2023

Conversation

ericrleung
Copy link
Contributor

@PrarthonaPaul
Copy link
Contributor

PrarthonaPaul commented Oct 6, 2023 •
edited
Loading

Hi @ericrleung
Thanks for the PR! Great work!
It seems that you squashed the changes from the other PR to the commit for this one.
Would you be able to rebase again to drop the other one, as opposed to squashing it? Lmk if you have any questions.

PrarthonaPaul
PrarthonaPaul approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@PrarthonaPaul PrarthonaPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fjuma
fjuma approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @ericrleung!

@Skyllarr Skyllarr merged commit 8b2219b into wildfly-security:2.x Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

@Skyllarr Skyllarr Skyllarr approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted +1 FJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericrleung @PrarthonaPaul @fjuma @Skyllarr