-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2662] Upgrade jakarta.json:jakarta.json-api from 2.0.0 to 2.1.2 #2046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabrielpadilh4 !
@gabrielpadilh4 Thanks for the PR! Looks like there are related test failures in CI: https://github.com/wildfly-security/wildfly-elytron/actions/runs/6633479695/job/18021291993?pr=2046 |
ELY-2662 Upgrade jakarta.json:jakarta.json-api from 2.0.0 to 2.1.2
88f342c
to
51d7f11
Compare
Hello @fjuma @Skyllarr it seems that jakarta.json 2.1 removed the default implementation from the specification api[1]. The implementation is eclipse parsson which changed some artifacts from Based on that, i also changed the What do you think ? [1] https://jakarta.ee/specifications/jsonp/2.1/ |
Thanks for the update, @gabrielpadilh4! @PrarthonaPaul Would you be able to check if this aligns with what is currently used by WildFly? |
It looks like WildFly-core still uses Glassfish: https://github.com/wildfly/wildfly-core/blob/43143580a4b60fef3671c557588d587c492ade1b/pom.xml#L205 |
@PrarthonaPaul also it's good to mention that wildfly-core uses version 1.1.6 of jakarta json glassfish while elytron uses 2.0.0 <version.org.glassfish.jakarta.json>1.1.6</version.org.glassfish.jakarta.json> <version.org.glassfish.jakarta.json>2.0.0</version.org.glassfish.jakarta.json> |
Thank you for the PR, FYI I have just resubmitted here to resolve the merge conflict #2111 |
Fixes: https://issues.redhat.com/browse/ELY-2662