[ELY-2704] Missing keystore password does not throw a meaningful exception #2175
Conversation
|
I have mixed throughts on this one - I have also been caught with this cryptic error message when using a PKCS12 KeyStore for trust information. Some keystore types in this situation can be used without a password just fine (PKCS12 not being one of them). The problem is the loading of the PKCS12 KeyStore quietly succeeded I think it just ends up being empty. On one hand the WARN feels safe to me as it just informs the user of something and may still work. But some users have a policy of requiring 0 WARN messages output, I wonder if this will risk catching some of those. |
| @@ -129,6 +129,10 @@ ConfigXMLParseException xmlDuplicateAuthenticationConfigurationName(String name, | |||
| ConfigXMLParseException xmlInvalidKeyStoreEntryType(@Param Location location, String alias, Class<?> expectedClass, | |||
| Class<?> actualClass); | |||
|
|
|||
| @LogMessage(level = WARN) | |||
There was a problem hiding this comment.
In our Elytron team call yesterday, we discussed that it might be better to use INFO here instead of WARN.
There was a problem hiding this comment.
Thanks @fjuma, updated.
https://issues.redhat.com/browse/ELY-2704
continuation of #2123