[ELY-2780] Logging in aggregaterealm changes authentication and authorization flow #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivassile
approved these changes
Aug 20, 2024
|
@fjuma When you have a chance, please review it. Thanks! |
darranl
reviewed
Sep 13, 2024
| if (authenticationIdentity.exists()) { | ||
| log.tracef("Authentication identity for principal [%s] found.", evidence.getDecodedPrincipal()); | ||
| } | ||
| log.tracef("Authentication identity for principal [%s] found.", evidence.getDecodedPrincipal()); |
There was a problem hiding this comment.
I think we may need to think about the message a bit more as it is now subtly different, we can confirm we obtained a RealmIdentity from the authenticationRealm but not sure we can fully declare it "found" as we no longer have a "not found" flow.
There was a problem hiding this comment.
Hi @darranl, thank you for the review, I have updated the messages.
darranl
approved these changes
Sep 16, 2024
|
Thank you @lvydra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ELY-2780