Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2547] Add Elytron Tool option to overwrite CLI script #2192

Closed
wants to merge 2 commits into from

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Sep 17, 2024

@darranl
Copy link
Contributor Author

darranl commented Sep 17, 2024

@lvydra FYI I mentioned this on the Jira issue but I have needed to temporarily revert so have raised a new PR here to restore the change but we are seeing CI failures.

@lvydra
Copy link
Contributor

lvydra commented Sep 17, 2024

Thanks @darranl, I will look at it.

@darranl
Copy link
Contributor Author

darranl commented Sep 17, 2024

Thanks @lvydra if you have any changes feel free to submit a PR to my topic branch to this or create a new PR yourself and we will close this one - will keep this one here for now so we don't lose your changes.

@lvydra
Copy link
Contributor

lvydra commented Sep 18, 2024

Hi @darranl I have opened a new PR #2194, and it seems that formerly failing tests are now passing, though there are some other failures, but those don't seem to be related to the changes.

@darranl
Copy link
Contributor Author

darranl commented Sep 18, 2024

Superseded by #2194

@darranl darranl closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants