[Issue_183][WFLY-19397] Add a Jakarta Data TCK runner #184
Conversation
bstansberry
force-pushed
the
Issue_183
branch
2 times, most recently
from
a82926a to
993b3a6
Compare
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| package ee.jakarta.tck.data.tools.annp; |
There was a problem hiding this comment.
Are we allowed to use this package name?
There was a problem hiding this comment.
I think so. The TCK guide points to the repo I copied this from as an example of how to run the TCK.
The build is specifically configured not to deploy this.
If I get time later I'll see how painful it would be to repackage this stuff.
| <feature-pack> | ||
| <groupId>${wildfly.feature.pack.groupId}</groupId> | ||
| <artifactId>${wildfly.feature.pack.artifactId}</artifactId> | ||
| <version>${version.org.wildfly.wildfly}</version> |
There was a problem hiding this comment.
FWIW if we leave the version.org.wildfly.wildfly property empty and use a channel, we don't have to upgrade the version for every new release.
There was a problem hiding this comment.
@jamezp I'd prefer to leave this for the future. I want this to work with all three of wildfly, wildfly-ee and wildfly-preview feature packs and I don't have time now to incorporate channel wiring and test the combinations.
data/wildfly-runner/src/test/java/org/hibernate/data/tck/ext/JPAProcessor.java
Outdated
Show resolved
Hide resolved
data/wildfly-runner/src/test/java/org/hibernate/data/tck/ext/HibernateLoadableExtension.java
Outdated
Show resolved
Hide resolved
data/wildfly-runner/src/test/java/embedded/GreetingService.java
Outdated
Show resolved
Hide resolved
bstansberry
force-pushed
the
Issue_183
branch
from
993b3a6 to
7fe838c
Compare
bstansberry
force-pushed
the
Issue_183
branch
from
7fe838c to
b34ef26
Compare
…mmunity stability
|
Note: This passes when run against a build of wildfly/wildfly#18434. Passes when run with any of the 3 'jboss.home' variants from that build (dist, ee-dist and preview/dist) as well as with the 3 feature packs (wildfly, wildfly-ee and wildfly-preview). |
Resolves #183
My (slightly modified from what's currently pushed) branch for wildfly/wildfly#18227 passes, both when pointing at an existing WildFly Preview build via -Djboss.home=/the/path and when using -Dversion.org.wildfly.wildfly=34.0.0.Beta1-SNAPSHOT and provisioning a server with the proposed 'jakarta-layer' layer.