Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a parent pom or bom for dependency management #73

Open
bstansberry opened this issue Feb 3, 2023 · 3 comments
Open

Create a parent pom or bom for dependency management #73

bstansberry opened this issue Feb 3, 2023 · 3 comments

Comments

@bstansberry
Copy link
Contributor

bstansberry commented Feb 3, 2023

We're independently controlling dep versions in the various maven modules in this repo, and it's messy. For example we have 3 different version of WildFly declared in 7 different locations, all badly out of date:

$ git grep version.org.wildfly\> | grep -v \{
authentication/wildfly-mods/profile.xml:                <version.org.wildfly>27.0.0.Alpha4</version.org.wildfly>
authentication/wildfly/pom.xml:        <version.org.wildfly>27.0.0.Alpha4</version.org.wildfly>
concurrency/concurrency-tck-runner/pom.xml:        <version.org.wildfly>27.0.0.Alpha3</version.org.wildfly>
faces/wildfly/pom.xml:        <version.org.wildfly>27.0.0.Alpha4</version.org.wildfly>
security/wildfly-mods/profile.xml:                <version.org.wildfly>27.0.0.Alpha4</version.org.wildfly>
security/wildfly/pom.xml:        <version.org.wildfly>27.0.0.Alpha4</version.org.wildfly>
wf-core-tck-runner/pom.xml:        <version.org.wildfly>27.0.0.Beta1</version.org.wildfly>

A fix for this would likely require changes to the Jenkins jobs that run these (perhaps just adding -am to mvn commands) and would probably force an adjustment to the maven versions of the various modules themselves (which seems needed regardless as none of them use -SNAPSHOT).

@jamezp
Copy link
Member

jamezp commented Jul 7, 2023

Should we use something like https://github.com/wildfly/wildfly-dev-tools/tree/main/parent-pom? My intention was not to do a release for every WildFly release, but we could. We could then just depend on the BOM and import that.

Or maybe for the BOM project, we create a org.wildfly.bom:wildfly-container-parent or something that is released. Then each POM in here can use that as the parent.

@bstansberry
Copy link
Contributor Author

@jamezp Make https://github.com/wildfly/wildfly-dev-tools/tree/main/parent-pom the parent? That's fine for plugins but I don't think we want production code versions managed by that repo.

Something from the boms project could work, but the boms project is going away, moving into the main WF code.

@jamezp
Copy link
Member

jamezp commented Jul 14, 2023

If the BOM project is moving back to WildFly we could just use that to ensure we get the correct components. We basically just need a BOM that will hold the version of WildFly we need. Maybe some other components too like the EJB client or things like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants