Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for 2 days ago/from now fails #33

Open
OskarPersson opened this issue May 24, 2018 · 2 comments
Open

Tests for 2 days ago/from now fails #33

OskarPersson opened this issue May 24, 2018 · 2 comments

Comments

@OskarPersson
Copy link

I get a few failures when running the tests on my machines:

PhantomJS 2.1.1 (Mac OS X 0.0.0) Filter: relativeDate Has the correct response for each interval FAILED
	Expected 'yesterday' to equal '2 days ago'.
	test/spec/relative-date-filter.js:38:57
	Expected '3 days from now' to equal '2 days from now'.
	test/spec/relative-date-filter.js:61:57

I'm guessing this has something to do with my timezone (Sweden - CEST) and/or DST.

@wildlyinaccurate
Copy link
Owner

wildlyinaccurate commented May 27, 2018

Aha, I forgot about this issue! I did have an open branch on the non-angular version of this module to fix this (wildlyinaccurate/tiny-relative-date#3) but I think it's just that the tests are wrong.

@OskarPersson
Copy link
Author

I ran the tests from the PR of the non-angular module locally and those passes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants