Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not catch replace / forks #1

Open
gyakovlev opened this issue Dec 2, 2019 · 1 comment
Open

does not catch replace / forks #1

gyakovlev opened this issue Dec 2, 2019 · 1 comment

Comments

@gyakovlev
Copy link

I haven't looked how it works, but I noticed that it does not detect replace directive from go.mod

for example: aerc-3.0 go.mod file has the following line:

replace github.com/gdamore/tcell => git.sr.ht/~sircmpwn/tcell v0.0.0-20190807054800-3fdb6bc01a50  

yet get-ego-vendor generates this "github.com/gdamore/tcell 84b54971b46c" as a vendor string, but really it should be "github.com/gdamore/tcell 3fdb6bc01a50 git.sr.ht/~sircmpwn/tcell"

This allows eclass to download forked snapshot ot tcell, as upstream intended.

@williamh
Copy link
Owner

williamh commented Mar 8, 2020

The current version of this tool uses go.sum instead of go.mod, so we should be good now.
Take a look and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants