-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with refined-github #12
Comments
This might be blocked, I don't see a way to know when the other extension has finished, and we can't just setTimeout due to a content security policy. |
@willklein Thanks for working on this - love the extension!
One of the If that's not ideal though, I'm sure we can find another way. |
Maybe |
@sindresorhus: Nice idea, I was thinking about that too. There might still be a race condition though. What if Another approach is agreeing on a DOM container that, if present, we both update. Whoever renders first inserts the container, and whoever renders later updates it. I think @DrewML's suggestion will probably work, I just didn't get a chance to try it yet. If so, that should delay rendering of |
Oh, on second thought, @sindresorhus's idea to emit a global event could also work without a race condition. Seems like these ideas are all "hacks," but that's what browser extensions are for. 😄 |
On repo homeages for README files, Refined GitHub removes the header where the button is inserted. Place the button in the same container as their edit button.
The text was updated successfully, but these errors were encountered: