Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Request: Freeshow #1156

Open
1 task done
gfactor opened this issue Aug 13, 2024 · 2 comments · May be fixed by #1289
Open
1 task done

App Request: Freeshow #1156

gfactor opened this issue Aug 13, 2024 · 2 comments · May be fixed by #1289
Labels
good first issue Good for newcomers new package New package proposal

Comments

@gfactor
Copy link

gfactor commented Aug 13, 2024

@philclifford philclifford added good first issue Good for newcomers new package New package proposal labels Sep 3, 2024
@gfactor
Copy link
Author

gfactor commented Jan 2, 2025

If it helps, here is the local freeshow update file I use. It should probably get a review from someone else before a PR is created. (...Or maybe the PR process is how a review happens?)

DEFVER=1
ARCHS_SUPPORTED="amd64 arm64"
get_github_releases "ChurchApps/FreeShow" "latest"
if [ "${ACTION}" != prettylist ]; then
URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | head -n1 | cut -d'"' -f4)"
VERSION_PUBLISHED="$(echo "${URL}" | cut -d'-' -f2)"
fi
PRETTY_NAME="FreeShow"
WEBSITE="https://freeshow.app/"
SUMMARY="A free and open-source presenter"

@philclifford
Copy link
Member

philclifford commented Jan 4, 2025

Thanks - that is more than helpful.

A PR is the best place for review especially if you have a working definition that could be merged. Just a quick suggestion (which a maintainer could make more easily and even commit for you in a PR context): take a look at the changes in #1253, which tweak the template to include the improvements that have been widely applied to

  • replace a lot of | head -n1 | calls by adding -m 1 to the preceeding grep
  • remove a lot of unnecessary echo calls by input redirection

Looking forward to a PR to review ...

@gfactor gfactor linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new package New package proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants