Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add region of interest to sig_noise #154

Closed
1 task done
wincowgerDEV opened this issue Oct 17, 2023 · 1 comment
Closed
1 task done

[Feature]: Add region of interest to sig_noise #154

wincowgerDEV opened this issue Oct 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wincowgerDEV
Copy link
Owner

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Description

I think it could be useful to allow a user to specify where the signal is and where the noise is in the sig_noise function.

Problem

Users currently have to use a second function to fine-tune signal and noise calculations and may have to deal with some complex logic to nest them together correctly.

Proposed Solution

Add specification for signla region and one for noise region in sig_noise. This could be passed first to using restrict_range to create a dataset for just the signal and one for just the noise. If null then use the whole dataset.

Alternatives Considered

Require the logic explained in the problem.

@wincowgerDEV wincowgerDEV added the enhancement New feature or request label Oct 17, 2023
@wincowgerDEV
Copy link
Owner Author

Fixing with #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant