Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkmode config does not work as configured #329

Open
philippdormann opened this issue Nov 15, 2021 · 2 comments
Open

darkmode config does not work as configured #329

philippdormann opened this issue Nov 15, 2021 · 2 comments
Labels
bug Something isn't working pending triage testing
Milestone

Comments

@philippdormann
Copy link

Describe the bug

not sure if it's my fault, but the darkmode config is not working when setting to darkMode: 'media'

the classes generated are only prefixed with .dark instead of wrapped within @media (prefers-color-scheme: dark) {

clean reproduction repo here

stackblitz reproduction here

System Info

System:
    OS: Windows 10 10.0.22000
    CPU: (6) x64 Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz
    Memory: 15.50 GB / 31.94 GB
  Binaries:
    Node: 17.0.1 - ~\AppData\Local\Volta\tools\image\node\17.0.1\node.EXE
    Yarn: 1.22.11 - ~\AppData\Local\Volta\tools\image\yarn\1.22.11\bin\yarn.CMD
    npm: 8.1.0 - ~\AppData\Local\Volta\tools\image\node\17.0.1\npm.CMD
  Browsers:
    Chrome: 95.0.4638.69
    Edge: Spartan (44.22000.120.0), Chromium (95.0.1020.53), ChromiumDev (93.0.910.5)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    svelte: 3.44.1 => 3.44.1
    svelte-windicss-preprocess: 4.1.6 => 4.1.6

Used Package Manager

yarn

@philippdormann philippdormann added bug Something isn't working pending triage labels Nov 15, 2021
@alexanderniebuhr
Copy link
Member

Thanks for the report. I will try to reproduce this issue, however I don't have it in my repos.

@alexanderniebuhr
Copy link
Member

Sorry for coming back lately. But I think you miss to define the configPath in your windi({}) call

@alexanderniebuhr alexanderniebuhr added this to the next milestone Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage testing
Projects
None yet
Development

No branches or pull requests

2 participants