Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir support still a problem #200

Open
srcrip opened this issue Jun 29, 2024 · 6 comments · Fixed by #206
Open

Elixir support still a problem #200

srcrip opened this issue Jun 29, 2024 · 6 comments · Fixed by #206

Comments

@srcrip
Copy link

srcrip commented Jun 29, 2024

See title. There's been several tickets auto closed by stale bot.

@PriceHiller
Copy link
Collaborator

Sorry for the long delay here, I'll take a look at a few of them.

In the meantime though, PRs are very much welcome.

@srcrip
Copy link
Author

srcrip commented Jul 16, 2024

No problem, check out some of the closed prs I think one of them may fix it

@PriceHiller
Copy link
Collaborator

Hey @srcrip can you take a look at the related PR (#206) and let me know if that works for Elixir? I have exactly 0 Elixir experience, so I need another person to let me know 🙂

@srcrip
Copy link
Author

srcrip commented Jul 22, 2024

Thanks @PriceHiller, I think this branch does in fact fix it for normal html tags in heex files.

If possible though, heex in elixir also has this other html-like tag that looks like this:

    <.stepper current_step={@current_step} target={@myself} class="lg:hidden -ml-1">
      <:step name={:personal}>
        <span class="me-2">1.</span>
        Personal <span class="hidden sm:inline-flex sm:ms-2">Info</span>
      </:step>

      <:step name={:work_experience}>
        <span class="me-2">2.</span>
        Work <span class="hidden sm:inline-flex sm:ms-2">Experience</span>
      </:step>

      <:step name={:education}>
        <span class="me-2">3.</span> Education
      </:step>

      <:step name={:other}>
        <span class="me-2">4.</span> Other
      </:step>

      <:step name={:review}>
        <span class="me-2">5.</span> Review
      </:step>
    </.stepper>

The <.stepper> is a phoenix component and the <:step> is a slot. It would be great if this plugin could successfully rename them too.

@PriceHiller
Copy link
Collaborator

PriceHiller commented Jul 23, 2024

I've merged in #206, but I'm not sure how viable the alternative heex tags are to add here as we are using binds to set the tags.

It would require some custom logic specifically for heex files.

@PriceHiller PriceHiller reopened this Jul 23, 2024
@srcrip
Copy link
Author

srcrip commented Sep 11, 2024

Does the Treesitter objects cover the entire tag identifier including the . at the beginning? If not does there need to be a treesitter change for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants