Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minico fails to build with Clang 19 #29

Open
jbeich opened this issue Oct 29, 2024 · 2 comments
Open

minico fails to build with Clang 19 #29

jbeich opened this issue Oct 29, 2024 · 2 comments

Comments

@jbeich
Copy link
Contributor

jbeich commented Oct 29, 2024

From error log:

$ export CC=clang CXX=clang++
$ cmake -G Ninja -B _build
$ cmake --build _build
[...]
In file included from examples/minico/main.cpp:7:
In file included from como/base/wayland/platform.h:15:
como/render/wayland/platform.h:255:19: error: no member named 'addRepaintFull' in 'platform<Base>'; did you mean 'addRepaint'?
  255 |             this->addRepaintFull();
      |                   ^~~~~~~~~~~~~~
      |                   addRepaint
como/render/wayland/platform.h:220:10: note: 'addRepaint' declared here
  220 |     void addRepaint(QRegion const& region)
      |          ^
@jbeich
Copy link
Contributor Author

jbeich commented Nov 1, 2024

Also affects theseus-ship.

@jbeich
Copy link
Contributor Author

jbeich commented Nov 3, 2024

Downstream simply removed unlock() methods. Only lock() method is actually used:

// Block compositor to prevent further compositing from crashing with a null workspace.
// TODO(romangg): Instead we should kill the compositor before that or remove all outputs.
platform.mod.render->lock();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant