Pull KWin patches (2024-05-23 - 2024-09-14) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing when the Desktop Effects shows up in the search results while looking for "shake cursor". BUG: 488850
The internal effects implement some of the core plasma functionality, for example screenshots, but being an effect is rather an implementation detail. Also we have pivoted towards unloading the desktop effects kcm and moving effect configuration in more appropriate places. BUG: 488988
* Use correct deletion icon (this isn't a file). * Use alternating list backgrounds to help line up the content on the left and right.
This KCM is usually called via the application menu, which uses kcmshell, so it doesn't benefit from the SystemSettings minimum size. Slightly increse its height, so there is more space for properties in the list views, either to configure them or to add them, so it feels less cramped.
This makes scrolling the list view much more responsive as there is no need to create new delegates BUG: 449275 FIXED-IN: 6.2
Changing the text and meaning of the button unexpectedly for a regular operation is not consistent with any other place, and disregarded by the HIG. The sheet can be closed by tapping outside of it, or throught the close button in its titlebar, as usual elsewhere.
The list to add properties can be empty because no entry matches the filter text or if all the properties have been already added. Show a placeholder instead of leaving the view just empty
- Remove unnecessary bindings to enabled: Properties that are not enabled are not shown in the list anyway, and it fixes QML warnings: RuleItemDelegate.qml:16:5: Unable to assign [undefined] to bool RuleItemDelegate.qml:93:17: Unable to assign [undefined] to bool - Remove unnecessary colorSet - Port away from javascript `var` - Remove outdated comment
Makes it consistent with other KCMs and and Kirigami KCMs. @teams/vdg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to listings in winft/como#27.