Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate QIcon dependency in plasma_window_management protocol #8

Open
romangg opened this issue Mar 19, 2020 · 2 comments
Open

Deprecate QIcon dependency in plasma_window_management protocol #8

romangg opened this issue Mar 19, 2020 · 2 comments

Comments

@romangg
Copy link
Member

romangg commented Mar 19, 2020

  • It makes testing difficult since QTEST_MAIN is needed instead of only QTEST_GUILESS_MAIN. That fires up QtWayland and by that makes autotests less predictable.
  • It makes usage of Plasma with non-Qt-compositors impossible, insofar it is also a blocker for Remove Qt dependency #1.
  • It is easy to transfer icons pixel by pixel. See for example XFixesGetCursorImage.
@romangg
Copy link
Member Author

romangg commented Mar 19, 2020

One option would be to replace the whole protocol with wlr_foreign_toplevel_management_unstable_v1 and some smaller custom extensions for VDs and so on.

@romangg
Copy link
Member Author

romangg commented Mar 21, 2020

Another option is to do it like wlr_foreign_toplevel_management_unstable_v1 and only send the app id such that the client can guess the icon from that.

From what I know there were issues in the past with this approach and XWayland clients that lead to the QIcon dependency in our protocol in the first place. So this needs some more investigation.

But wlroots does it this way only and it's apparently enough. Also all XWayland clients I tested sent an app ID, which were:

  • firefox
  • chromium
  • gimp
  • xeyes
  • neverball
  • steam
  • xfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant