Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rest should be in token, not combinator #636

Open
epage opened this issue Dec 20, 2024 · 0 comments
Open

rest should be in token, not combinator #636

epage opened this issue Dec 20, 2024 · 0 comments
Labels
A-combinator Area: combinators C-enhancement Category: Raise on the bar on expectations

Comments

@epage
Copy link
Collaborator

epage commented Dec 20, 2024

As its dealing with taking slices. It might also need to be renamed to take_rest.

We also have rest_len. I wonder if we should do that as take_rest.len() and have Parser::len that returns how much was taken (offset or count?)
@epage epage added A-combinator Area: combinators C-enhancement Category: Raise on the bar on expectations labels Dec 20, 2024
@winnow-rs winnow-rs deleted a comment Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-combinator Area: combinators C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage