Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use window icon in window properties dialog #2224

Open
Enyium opened this issue Oct 3, 2024 · 0 comments
Open

Use window icon in window properties dialog #2224

Enyium opened this issue Oct 3, 2024 · 0 comments
Assignees

Comments

@Enyium
Copy link

Enyium commented Oct 3, 2024

Description of the feature, modification, idea or suggestion

Under a process's "Windows" tab, you can double-click a window to show more properties of that window. In that dialog, a large icon is shown. But that icon seems to be the .exe icon, and not the window icon.

The same is true for the window of the properties dialog itself; it seems to use the .exe icon, and falls back to System Informer's own icon, if the .exe doesn't have an icon.

These places should use the window's own icon.


It would also be nice to have both the big and the small icon from WM_GETICON listed in the list view under the "General" subsection to be able to know whether the window defines them. (The "Class" subsection already lets you know whether the class defines them.)

Proposed implementation details (optional)

System Informer should query the icon using WM_GETICON. As the remarks on the docs page say, GetClassLongPtr() should be tried next.

  • The big icon - with the small icon as the fall back - needs to be used for display in the properties dialog's client area.
  • The big as well as the small icon needs to be used for the respective icon of the properties dialog itself. These icons could probably use each other as the fallback.
@dmex dmex self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants