Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom logout endpoint URL #2

Open
marcusforsberg opened this issue Jan 10, 2020 · 1 comment
Open

Allow setting custom logout endpoint URL #2

marcusforsberg opened this issue Jan 10, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed third-party
Milestone

Comments

@marcusforsberg
Copy link
Member

SAML2-js doesn't seem to implement a way to set a custom logout URL. It instead uses the assert URL. We need a way around this. See Clever/saml2#159, Clever/saml2#139

@marcusforsberg marcusforsberg added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed third-party and removed documentation Improvements or additions to documentation enhancement New feature or request labels Jan 10, 2020
@marcusforsberg marcusforsberg added this to the SAML Logout milestone Jan 10, 2020
@FossPrime
Copy link
Contributor

FossPrime commented Apr 27, 2023

We don't need a way a round this... The request we get from IDP is drastically different from a login assertion, so it can be handled with a logout response. So is the response, which can be handled with the same or a separate redirect.

saml-slo

We can do it by using the SAML session token, if it doesn't exist, JWT should be disallowed. As long as we update the user, remove the session, and disable fallback authentication. we'd have to extend the JWT strategy as SamlJWTStrategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed third-party
Projects
None yet
Development

No branches or pull requests

2 participants