Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with *ignore and not pass pushes #26

Open
RyanWor opened this issue May 2, 2011 · 3 comments
Open

Comply with *ignore and not pass pushes #26

RyanWor opened this issue May 2, 2011 · 3 comments

Comments

@RyanWor
Copy link

RyanWor commented May 2, 2011

It seems that even when I have users set to *ignore, and do not see them on my clients, I still get push notifications on pm/mention/hilight from those users. It would be great if *colloquy would read *ignore's .registry file and ignore pushes from those entries.

@RyanWor
Copy link
Author

RyanWor commented May 4, 2011

It possible this may have been more an issue with ignore not working properly. Not positive. I am having trouble replicating now so I will close this for now.

@RyanWor RyanWor closed this as completed May 4, 2011
@RyanWor RyanWor reopened this May 13, 2011
@RyanWor
Copy link
Author

RyanWor commented May 13, 2011

OK. More testing and verified this is true. Even those that are ignored via *ignore get pushed. Another problem is there is no reading of the registry of *ignore since the module is broken and doesn't save correctly to begin with.

So I guess this would best be a request to implement a ignore registry for colloquypush. This way users could add those that they don't want pushes for, not to mention the ability to block notices such as those from Global, and those about SSL, ect when you connect. (If the server loses connection or znc has to restart for any reason, it quickly becomes a flood of pushes)

@kylef
Copy link

kylef commented Feb 9, 2012

@pyrofallout the ignore you are talking about, is this a ZNC module?

If it is a module, then it is important to know the order in which modules are loaded effects how the module calls work. If the ignore module tells ZNC to "haltcore" on the line, then ZNC will not tell any more modules about it. So if colloquy is loaded before ignore then it will send the notification before ignore has blocked it. You can try reloading colloquy to change the ordering. This should result in ignore blocking the message before colloquy module sees the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants