You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The annotation @EnableWireMock should itself be annotated with @Inherited so that it is obvious it can be applied to classes that will be inherited by actual tests.
The WireMockContextCustomizerFactory does actually recursively search a class' superclasses for @EnableWireMock annotations, but this is not obvious from the documentation (neither README.md nor the Javadocs on @EnableWireMock mention it). Instead of performing the recursive search, annotating with @Inherited would make it obvious to users that the annotation can be used on super classes, as well as remove the need to recursively search the ancestors of the current class to find the annotation.
Alternatively, the documentation should be updated to indicate that superclasses will be searched.
References
No response
The text was updated successfully, but these errors were encountered:
Proposal
The annotation
@EnableWireMock
should itself be annotated with@Inherited
so that it is obvious it can be applied to classes that will be inherited by actual tests.The
WireMockContextCustomizerFactory
does actually recursively search a class' superclasses for@EnableWireMock
annotations, but this is not obvious from the documentation (neitherREADME.md
nor the Javadocs on@EnableWireMock
mention it). Instead of performing the recursive search, annotating with@Inherited
would make it obvious to users that the annotation can be used on super classes, as well as remove the need to recursively search the ancestors of the current class to find the annotation.Alternatively, the documentation should be updated to indicate that superclasses will be searched.
References
No response
The text was updated successfully, but these errors were encountered: