From c256d5b0b9585b442aa5939f73802659e911690e Mon Sep 17 00:00:00 2001 From: = Date: Wed, 16 Oct 2024 13:01:30 +0900 Subject: [PATCH] update changelog, fix test --- CHANGELOG.md | 2 ++ v2/gcd_test.go | 7 +++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aec465c..febda0f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,6 @@ # Changelog (2024) +- 2.3.5 (Oct 16) + - Fix apigen to use ToT from github for downloading json files. Update to latest protocol - 2.3.4 (Mar 18) - Fix return types for calls that return two-dimensional arrays - 2.3.3 (Jan 31) diff --git a/v2/gcd_test.go b/v2/gcd_test.go index 708b041..72e4b47 100644 --- a/v2/gcd_test.go +++ b/v2/gcd_test.go @@ -62,10 +62,6 @@ func testCleanUp() { } func TestDeleteProfileOnExit(t *testing.T) { - if runtime.GOOS == "windows" { - //t.Skip("windows will hold on to the process handle too long") - } - debugger := NewChromeDebugger(WithDeleteProfileOnExit(), WithFlags([]string{"--headless"}), ) @@ -75,6 +71,9 @@ func TestDeleteProfileOnExit(t *testing.T) { if err != nil { t.Fatalf("error starting chrome: %s\n", err) } + + debugger.NewTab() + debugger.ExitProcess() time.Sleep(3 * time.Second) if stat, err := os.Stat(profileDir); err == nil {