From 89bab1e70786123fbe933a9d7a1b80c9334dcc5f Mon Sep 17 00:00:00 2001 From: Bjorn Lu Date: Fri, 16 Aug 2024 23:03:27 +0800 Subject: [PATCH] Reduce prerender dynamic value warning false positives (#11745) --- .changeset/new-pillows-kick.md | 5 +++++ packages/astro/src/vite-plugin-env/index.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/new-pillows-kick.md diff --git a/.changeset/new-pillows-kick.md b/.changeset/new-pillows-kick.md new file mode 100644 index 000000000000..ccc705d67543 --- /dev/null +++ b/.changeset/new-pillows-kick.md @@ -0,0 +1,5 @@ +--- +'astro': patch +--- + +Prints prerender dynamic value usage warning only if it's used diff --git a/packages/astro/src/vite-plugin-env/index.ts b/packages/astro/src/vite-plugin-env/index.ts index 350a29b7ffe1..79bdad4cf510 100644 --- a/packages/astro/src/vite-plugin-env/index.ts +++ b/packages/astro/src/vite-plugin-env/index.ts @@ -176,8 +176,8 @@ export default function envVitePlugin({ settings, logger }: EnvPluginOptions): v // TODO: Remove in Astro 5 let exportConstPrerenderStr: string | undefined; s.replace(exportConstPrerenderRe, (m, key) => { - exportConstPrerenderStr = m; if (privateEnv[key] != null) { + exportConstPrerenderStr = m; return `export const prerender = ${privateEnv[key]}`; } else { return m;