Remove @astrojs/lit #11680
Merged
Remove @astrojs/lit #11680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the Lit integration as an official integration. The reasons for doing so in 5.0: - Only 1% of Astro users use this integration. - SSR support in Lit is at a lower-level of support due to be a Labs project: https://lit.dev/docs/libraries/labs/, and has been in this state since we added support a couple of years ago. - The maintenance cost of fixing bugs in this integration is too high given the low usage. Some PRs for upgrading Lit versions have taken quite a long time. We can't justify the core team being responsible for this going forward. - There used to be community contributions to fix bugs but this has fallen off for various reasons. Given that, this PR removes the integration as one that is officially supported by the Astro core team. Interested community members are encouraged to fork the integration and continue the development in another repository.
|
github-actions
bot
added
pkg: lit
|
There's a hack here you might be able to remove too: (there's also a mention of the integration in that same file) |
|
in packages/astro/src/runtime/server/render/component.ts there's also a mention of the integration for the error message |
Princesseuh
approved these changes
Aug 13, 2024
ematipico
approved these changes
Aug 13, 2024
|
Please don't remove Lit, this small lib has not alternative. SSR support is on the way. FYI @justinfagnani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This removes the Lit integration as an official integration. The reasons for doing so in 5.0:
Given that, this PR removes the integration as one that is officially supported by the Astro core team. Interested community members are encouraged to fork the integration and continue the development in another repository.
Testing
Docs