Warning messages when reading cookies in middleware functions with hybrid output

[RaphaelBossek]

Astro Info

Astro                    v4.14.2
Node                     v18.17.1
System                   Linux (x64)
Package Manager          pnpm
Output                   hybrid
Adapter                  @astrojs/node
Integrations             set-prerender

If this issue only occurs in one browser, which browser is a problem?

Not a browser problem

Describe the Bug

While reading cookies in middleware function result in following warning:

[WARN] Astro.request.headers is unavailable in "static" output mode, and in prerendered pages within "hybrid" and "server" output modes. If you need access to request headers, make sure that output is configured as either "server" or output: "hybrid" in your config file, and that the page accessing the headers is rendered on-demand.

What's the expected result?

No warning message.

Link to Minimal Reproducible Example

https://stackblitz.com/~/github.com/RaphaelBossek/astro-auth-middleware-test

Participation

• I am willing to submit a pull request for this issue.

[cielorz]

I think this issue would be same to #11751, @bholmesdev

[ematipico]

@RaphaelBossek can you provide more context or reasons about why this is a bug?

In particular, please provide:

• instructions on how to reproduce the warning
• which pages you're rendering, that produce the warning

[RaphaelBossek]

The advice is to change to output mode "hybrid" but I'm in "hybrid" mode.

This warning can be surpressed when the cookie getter code is removed from the middleware function.

I've applied an "working" example at https://stackblitz.com/~/github.com/RaphaelBossek/astro-auth-middleware-test with this warning, so your questions are answered within the short "code". Could you pleaes precise your questions based on the Minimal, Reproducible Example.

[cielorz]

I think this warning might brought by recent changes in astro action. Before ver 4.13.2 there is no warning when build.

…

________________________________ From: @hephaistos_DE ***@***.***> Sent: Sunday, August 18, 2024 8:31:25 PM To: withastro/astro ***@***.***> Cc: Ciel ***@***.***>; Comment ***@***.***> Subject: Re: [withastro/astro] Warning messages when reading cookies in middleware functions with hybrid output (Issue #11756) The advice is to change to output mode "hybrid" but I'm in "hybrid" mode. I've applied an "working" example at https://stackblitz.com/~/github.com/RaphaelBossek/astro-auth-middleware-test with this warning, so your questions are answered within the short "code". Could you pleaes precise your questions based on the Minimal, Reproducible Example. — Reply to this email directly, view it on GitHub<#11756 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALFPQ5J2NGJS5WEZEA7AHT3ZSCHZ3AVCNFSM6AAAAABMVGZ6BOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGI2DKMZUGY>. You are receiving this because you commented.Message ID: ***@***.***>

[hkbertoson]

Its the same as #11751 The error message was fixed at one point. But then got reintroduced at some point.

[bholmesdev]

Hey @RaphaelBossek! Thanks for reporting. It seems that middleware runs on prerendered routes in development, which trips that warning log when accessing headers or cookies.

We have some Astro maintainers discussing how to expose whether a route is prerendered or not so you can check this from middleware. You can join the discord to discussion in #feedback-ideas! For now, you can safely ignore the warning.

[florian-lefebvre]

It's available in 5.0 beta, you can use context.isPrererendered

[bholmesdev]

context.isPrererendered is now supported! @RaphaelBossek can you try this API on the 5.0 beta and give us your feedback?

[mlafeldt]

Looks like it's still called _isPrerendered ...

astro/packages/astro/src/core/render-context.ts

Line 242 in 1720c5b

_isPrerendered: isPrerendered,

... and not officially part of the context yet.

astro/packages/astro/src/actions/runtime/middleware.ts

Line 23 in 1720c5b

if ((context as any)._isPrerendered) {

Apart from that, it works fine!

[florian-lefebvre]

That's because the change is on the next branch

[ematipico]

I just tried the user's reproduction, and I can't see the warning anymore when using ctx.isPrendered. The fix is only available in Astro v5.

Closing as completed