Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue useId cannot generate unique identifiers for islands #11881

Closed
1 task
MRamonLeon opened this issue Aug 30, 2024 · 3 comments · Fixed by #12112
Closed
1 task

Vue useId cannot generate unique identifiers for islands #11881

MRamonLeon opened this issue Aug 30, 2024 · 3 comments · Fixed by #12112
Assignees
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: vue Related to Vue (scope)

Comments

@MRamonLeon
Copy link

MRamonLeon commented Aug 30, 2024

Astro Info

Astro                    v4.15.1
Node                     v20.5.1
System                   macOS (arm64)
Package Manager          unknown
Output                   hybrid
Adapter                  @astrojs/node
Integrations             @astrojs/vue

If this issue only occurs in one browser, which browser is a problem?

All browsers.

Describe the Bug

I would like to have unique ids when using new Vue 3.5 useId method in different Astro islands. Basically apply the same you did at #6976. This issue would be the equivalent of #6849 for Vue 3.5 release.

Current improvable result

Screenshot 2024-08-30 at 10 08 26

What's the expected result?

We have a way to generate unique ids for each island using Vue's useId or the recommended Astro method.

Link to Minimal Reproducible Example

https://stackblitz.com/~/github.com/MRamonLeon/AstroAndVue35UseId?file=README.md

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 30, 2024
@ematipico ematipico added - P2: nice to have Not breaking anything but nice to have (priority) and removed needs triage Issue needs to be triaged labels Aug 30, 2024
@ematipico
Copy link
Member

Looking forward to your PR!

@MRamonLeon
Copy link
Author

@ematipico Sorry I checked the Participation check by mistake.

@florian-lefebvre florian-lefebvre added the pkg: vue Related to Vue (scope) label Oct 3, 2024
@florian-lefebvre florian-lefebvre self-assigned this Oct 3, 2024
@ematipico
Copy link
Member

ematipico commented Oct 3, 2024

PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants