Fix-component-undefined-svelte-v5

[hermit99]

Changes

Small code enhancement, which is easy to understand.

• Fix 'component is not defined' console error when unmounting svelte 5 component.

Console error:

Testing

Defensive code added and tested locally.

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: ffa87ee

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[martrapp]

Thanks @bluwy for pointing out!

@hermit99, thank you very much for providing this PR!
I'll have a look at #12116 and we might fix them both in the same way as the issues result from the same refactoring.

[martrapp]

Hi @hermit99, the suggestion would be to revert the file and only move the addEventlistener from line 44 up to line 42 at the end of the else-block. That would ensure that component is always defined when referenced and would also fix the issue that the listener is currently added too often

[hermit99]

Thanks @martrapp. Pardon me as I'm new to Astro's code base. Your suggestion makes more sense, and I really appreciate it ❤️

[martrapp]

Thank you very much for taking care! 💜
The suggestion came from #12116 (comment)