Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly serialize Infinity as island props #12121

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Oct 4, 2024

Changes

Handles the serialization of Inifinity and -Infinity as props for islands.

Fixes #12088

Testing

Adds unit and e2e tests

Docs

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 88ee1d1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 4, 2024
@ematipico ematipico merged commit 2490ceb into main Oct 4, 2024
13 checks passed
@ematipico ematipico deleted the serialise-infinity branch October 4, 2024 10:53
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinity is null
3 participants