Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sitemap entries for fallback routes (i18n) #12135

Open
1 task
xentobias opened this issue Oct 6, 2024 · 1 comment
Open
1 task

Missing sitemap entries for fallback routes (i18n) #12135

xentobias opened this issue Oct 6, 2024 · 1 comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: rss Related to the `@astrojs/rss` package (scope)

Comments

@xentobias
Copy link

Astro Info

Astro                    v4.15.11
Node                     v18.20.3
System                   Linux (x64)
Package Manager          unknown
Output                   static
Adapter                  none
Integrations             @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

The "@astrojs/sitemap" integration does not generate sitemap locations for my international routes (i18n) when the i18n.routing.fallbackType is set to "rewrite" in the configuration.

What's the expected result?

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:news="http://www.google.com/schemas/sitemap-news/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:image="http://www.google.com/schemas/sitemap-image/1.1" xmlns:video="http://www.google.com/schemas/sitemap-video/1.1">
  <url>
    <loc>http://localhost:3000/</loc>
  </url>
  <url>
    <loc>http://localhost:3000/docs/</loc>
  </url>
  <url>
    <loc>http://localhost:3000/de/</loc>
  </url>
  <url>
    <loc>http://localhost:3000/de/docs/</loc>
  </url>
</urlset>

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-xntzfh-tefqcq?file=dist%2Fsitemap-0.xml

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Oct 6, 2024
@bluwy bluwy added the feat: i18n Related to internalization (scope) label Oct 7, 2024
@ematipico ematipico added - P2: nice to have Not breaking anything but nice to have (priority) pkg: rss Related to the `@astrojs/rss` package (scope) and removed needs triage Issue needs to be triaged feat: i18n Related to internalization (scope) labels Oct 7, 2024
@ematipico
Copy link
Member

PRs welcome. At the moment, this feature isn't supported by the RSS integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: rss Related to the `@astrojs/rss` package (scope)
Projects
None yet
Development

No branches or pull requests

3 participants