Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/upgrade announces integration updates that are already up to date #12455

Closed
1 task
jurajkapsz opened this issue Nov 16, 2024 · 0 comments · Fixed by #12577
Closed
1 task

@astrojs/upgrade announces integration updates that are already up to date #12455

jurajkapsz opened this issue Nov 16, 2024 · 0 comments · Fixed by #12577
Labels
5.0 beta Related to the Astro 5.0 beta - P2: nice to have Not breaking anything but nice to have (priority) pkg: upgrade Related to `@astrojs/upgrade` (scope)

Comments

@jurajkapsz
Copy link
Contributor

Astro Info

Astro                    v5.0.0-beta.8
Node                     v20.11.1
System                   Linux (x64)
Package Manager          pnpm
Output                   static
Adapter                  @astrojs/node
Integrations             @astrojs/mdx
                         build/images
                         build/cleanup
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Running pnpm dlx @astrojs/upgrade beta:

image

, but the to be updated packages are already up to date, from package.json:

  "dependencies": {
    "@astrojs/check": "^0.9.4",
    "@astrojs/mdx": "4.0.0-beta.3",
    "@astrojs/node": "9.0.0-beta.3",
    "@astrojs/sitemap": "^3.2.1",

Happens repeatedly.

Maybe it's because of the ^ package version denotion.

What's the expected result?

Already up to date packages should be marked as such/not processed.

Link to Minimal Reproducible Example

Not sure if there can be a stackblitz repro for this one.

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Nov 16, 2024
@jurajkapsz jurajkapsz changed the title @astrojs/upgrade announces integration updates that are already updated @astrojs/upgrade announces integration updates that are already up to date Nov 16, 2024
@ascorbic ascorbic added pkg: upgrade Related to `@astrojs/upgrade` (scope) - P2: nice to have Not breaking anything but nice to have (priority) 5.0 beta Related to the Astro 5.0 beta and removed needs triage Issue needs to be triaged labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 beta Related to the Astro 5.0 beta - P2: nice to have Not breaking anything but nice to have (priority) pkg: upgrade Related to `@astrojs/upgrade` (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants