Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server islands support for MDX #12574

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

apatel369
Copy link
Contributor

Changes

reopening #12446 for main
Closes #12252

Server Islands are not rendering as islands in .mdx files because server islands metadata is not added for JSX components in MDX files.
Even after adding server islands metadata, the issue persists because transform function in vite-plugin-server-islands.ts file runs before server metadata is added in rehype.ts file.

I found that vite-plugin-server-islands.ts is added last in create-vite.ts and has enforce: 'post' but still transform function is running before the server meta data is added.

I am looking for feedback and guidance from Astro contributors on how to fix it.

Testing

TODO

Docs

Not needed

Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: 18449c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 30, 2024
@apatel369 apatel369 changed the title Arpan #12252 mdx islands feat: add support for server islands for MDX Nov 30, 2024
@apatel369 apatel369 marked this pull request as draft November 30, 2024 20:39
@apatel369 apatel369 changed the title feat: add support for server islands for MDX feat: add server islands support for MDX Nov 30, 2024
Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #12574 will not alter performance

Comparing apatel369:arpan-#12252-mdx-islands (18449c8) with main (97f413f)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Islands not rendering as islands in .mdx files
2 participants