Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro 5 breaks sourcemaps #12703

Closed
1 task
lilnasy opened this issue Dec 10, 2024 · 2 comments · Fixed by #12877
Closed
1 task

Astro 5 breaks sourcemaps #12703

lilnasy opened this issue Dec 10, 2024 · 2 comments · Fixed by #12877
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: server islands Related to Server Islands (scope)

Comments

@lilnasy
Copy link
Contributor

lilnasy commented Dec 10, 2024

Astro Info

Astro                    v5.0.4
Node                     v18.20.3
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  @astrojs/node
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

The logs report sourcemaps may be broken because of server islands.

06:46:03 [build] Building static entrypoints...
[plugin astro:server-islands] Sourcemap is likely to be incorrect: a plugin (astro:server-islands) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
06:46:10 [vite] ✓ built in 5.94s

And in fact, they are. error stacktraces show compiled locations.
image

What's the expected result?

The same result from Astro 4

image

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-gvpoqswg?file=astro.config.mjs,src%2Fpages%2Findex.astro&on=stackblitz

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 10, 2024
@ascorbic ascorbic added feat: server islands Related to Server Islands (scope) - P3: minor bug An edge case that only affects very specific usage (priority) and removed needs triage Issue needs to be triaged labels Dec 10, 2024
lilnasy added a commit to lilnasy/tic-tac-toe that referenced this issue Dec 14, 2024
@lilnasy
prevent warning from withastro/astro#12703
b6daf0b
@jorgeluiz1586
Copy link

Hello, I'm having the same problem, when I updated Astro and Vite to the latest version, I saw that new commits were uploaded but the error persists.

@lilnasy
Copy link
Contributor Author

lilnasy commented Dec 18, 2024

As of [email protected], it's just a warning. The sourcemaps themselves are functional.

@bluwy bluwy mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: server islands Related to Server Islands (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sourcemap warning in server islands plugin withastro/astro
3 participants
@ascorbic @jorgeluiz1586 @lilnasy