Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H1 Style in about.astro should be removed in branches unit-5/start, unit-6/start, complete #28

Open
pellison512 opened this issue Mar 15, 2024 · 0 comments

Comments

@pellison512
Copy link

pellison512 commented Mar 15, 2024

Hi, I'm not sure if this is the correct place to raise the issue so please let me know if there's somewhere better.

I'm a new Astro developer following along with your tutorial when I got to section 4 and came across the "Try it yourself" language:

Delete anything from each page that that page is no longer responsible for rendering, because it is being handled by the layout, including:

HTML elements
Components and their imports
CSS rules in a <style> tag (e.g.

in your About page)

<script> tags

The <h1> CSS rule is still present in these branches, and has no effect on the CSS of the site. Therefore, I think it should be removed from branches unit-5/start, unit-6/start, and complete.

I have a branch with this change based off unit-5/start, but I'm not sure how to contribute.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant