From c2d857e4830e7044d7b7ec30ae5d93ca399b002f Mon Sep 17 00:00:00 2001
From: Princesseuh <3019731+Princesseuh@users.noreply.github.com>
Date: Fri, 12 Jul 2024 01:35:55 +0200
Subject: [PATCH] fix: remaining type issues

---
 biome.json                                    | 10 ++++++
 .../test/bad-styles/unclosed-style.ts         |  5 +--
 packages/compiler/test/parse/ast.ts           |  9 +++---
 packages/compiler/test/parse/escaping.ts      |  2 +-
 packages/compiler/test/parse/fragment.ts      |  9 +++---
 .../test/parse/multibyte-characters.ts        |  5 +--
 packages/compiler/test/parse/orphan-head.ts   |  4 +--
 packages/compiler/test/parse/position.ts      | 31 ++++++++++---------
 packages/compiler/test/parse/serialize.ts     |  2 +-
 packages/compiler/test/stress/index.ts        |  2 +-
 packages/compiler/test/tsx-errors/eof.ts      |  3 +-
 .../test/tsx-errors/fragment-shorthand.ts     |  3 +-
 .../test/tsx-errors/unfinished-component.ts   |  3 +-
 packages/compiler/test/tsx-sourcemaps/tags.ts |  2 +-
 packages/compiler/test/utils.ts               |  4 +--
 15 files changed, 56 insertions(+), 38 deletions(-)

diff --git a/biome.json b/biome.json
index 26f9d9dc..4fdfd3fa 100644
--- a/biome.json
+++ b/biome.json
@@ -51,6 +51,16 @@
     }
   },
   "overrides": [
+    {
+      "include": ["**/stress/**"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noConsoleLog": "off"
+          }
+        }
+      }
+    },
     {
       "include": ["package.json"],
       "json": {
diff --git a/packages/compiler/test/bad-styles/unclosed-style.ts b/packages/compiler/test/bad-styles/unclosed-style.ts
index 93c468ca..4b1276af 100644
--- a/packages/compiler/test/bad-styles/unclosed-style.ts
+++ b/packages/compiler/test/bad-styles/unclosed-style.ts
@@ -1,10 +1,11 @@
 import { type ParseResult, parse } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { ElementNode } from '../../types.js';
 
 test('can compile unfinished style', async () => {
 	let error = 0;
-	let result: ParseResult;
+	let result: ParseResult = {} as ParseResult;
 
 	try {
 		result = await parse('<style>');
@@ -12,7 +13,7 @@ test('can compile unfinished style', async () => {
 		error = 1;
 	}
 
-	const style = result.ast.children[0];
+	const style = result.ast.children[0] as ElementNode;
 	assert.equal(error, 0, 'Expected to compile with unfinished style.');
 	assert.ok(result.ast, 'Expected to compile with unfinished style.');
 	assert.equal(style.name, 'style', 'Expected to compile with unfinished style.');
diff --git a/packages/compiler/test/parse/ast.ts b/packages/compiler/test/parse/ast.ts
index fbdc4c29..47ab5bc7 100644
--- a/packages/compiler/test/parse/ast.ts
+++ b/packages/compiler/test/parse/ast.ts
@@ -1,6 +1,7 @@
-import { parse } from '@astrojs/compiler';
+import { type ParseResult, parse } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { ElementNode } from '../../types.js';
 
 const FIXTURE = `
 ---
@@ -11,7 +12,7 @@ let value = 'world';
 <div></div>
 `;
 
-let result: TransformResult;
+let result: ParseResult;
 test.before(async () => {
 	result = await parse(FIXTURE);
 });
@@ -36,12 +37,12 @@ test('element', () => {
 });
 
 test('element with no attributes', () => {
-	const [, , , element] = result.ast.children;
+	const [, , , element] = result.ast.children as ElementNode[];
 	assert.equal(element.attributes, [], `Expected the "attributes" property to be an empty array`);
 });
 
 test('element with no children', () => {
-	const [, , , element] = result.ast.children;
+	const [, , , element] = result.ast.children as ElementNode[];
 	assert.equal(element.children, [], `Expected the "children" property to be an empty array`);
 });
 
diff --git a/packages/compiler/test/parse/escaping.ts b/packages/compiler/test/parse/escaping.ts
index 5bea379b..007ffea2 100644
--- a/packages/compiler/test/parse/escaping.ts
+++ b/packages/compiler/test/parse/escaping.ts
@@ -12,7 +12,7 @@ test('ampersand', async () => {
 		{
 			children: [{ value: output }],
 		},
-	] = result.ast.children;
+	] = result.ast.children as any;
 	assert.equal(output, STYLE, 'Expected AST style to equal input');
 });
 
diff --git a/packages/compiler/test/parse/fragment.ts b/packages/compiler/test/parse/fragment.ts
index 0dcb60aa..a391ee78 100644
--- a/packages/compiler/test/parse/fragment.ts
+++ b/packages/compiler/test/parse/fragment.ts
@@ -1,22 +1,23 @@
-import { parse } from '@astrojs/compiler';
+import { type ParseResult, parse } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { FragmentNode } from '../../types.js';
 
 const FIXTURE = '<>Hello</><Fragment>World</Fragment>';
 
-let result: TransformResult;
+let result: ParseResult;
 test.before(async () => {
 	result = await parse(FIXTURE);
 });
 
 test('fragment shorthand', () => {
-	const [first] = result.ast.children;
+	const [first] = result.ast.children as FragmentNode[];
 	assert.equal(first.type, 'fragment', 'Expected first child to be of type "fragment"');
 	assert.equal(first.name, '', 'Expected first child to have name of ""');
 });
 
 test('fragment literal', () => {
-	const [, second] = result.ast.children;
+	const [, second] = result.ast.children as FragmentNode[];
 	assert.equal(second.type, 'fragment', 'Expected second child to be of type "fragment"');
 	assert.equal(second.name, 'Fragment', 'Expected second child to have name of ""');
 });
diff --git a/packages/compiler/test/parse/multibyte-characters.ts b/packages/compiler/test/parse/multibyte-characters.ts
index f5377e23..8615ecdb 100644
--- a/packages/compiler/test/parse/multibyte-characters.ts
+++ b/packages/compiler/test/parse/multibyte-characters.ts
@@ -13,9 +13,10 @@ test('properly maps the position', async () => {
 	const {
 		ast: { children },
 	} = await parse(FIXTURE);
+
 	const text = children[1];
-	assert.equal(text.position.start.offset, 5, 'properly maps the text start position');
-	assert.equal(text.position.end.offset, 8, 'properly maps the text end position');
+	assert.equal(text.position?.start.offset, 5, 'properly maps the text start position');
+	assert.equal(text.position?.end?.offset, 8, 'properly maps the text end position');
 });
 
 test.run();
diff --git a/packages/compiler/test/parse/orphan-head.ts b/packages/compiler/test/parse/orphan-head.ts
index 8643162f..128f97ef 100644
--- a/packages/compiler/test/parse/orphan-head.ts
+++ b/packages/compiler/test/parse/orphan-head.ts
@@ -1,4 +1,4 @@
-import { parse } from '@astrojs/compiler';
+import { type ParseResult, parse } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
 
@@ -18,7 +18,7 @@ const FIXTURE = `
 </html>
 `;
 
-let result: TransformResult;
+let result: ParseResult;
 test.before(async () => {
 	result = await parse(FIXTURE);
 });
diff --git a/packages/compiler/test/parse/position.ts b/packages/compiler/test/parse/position.ts
index a623a46e..b805cbee 100644
--- a/packages/compiler/test/parse/position.ts
+++ b/packages/compiler/test/parse/position.ts
@@ -1,6 +1,7 @@
 import { parse } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { ElementNode, FrontmatterNode } from '../../types.js';
 
 test('include start and end positions', async () => {
 	const input = `---
@@ -10,9 +11,9 @@ test('include start and end positions', async () => {
 <iframe>Hello</iframe><div></div>`;
 	const { ast } = await parse(input);
 
-	const iframe = ast.children[1];
+	const iframe = ast.children[1] as ElementNode;
 	assert.is(iframe.name, 'iframe');
-	assert.ok(iframe.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(iframe.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(iframe.position.end, 'Expected serialized output to contain an end position');
 });
 
@@ -25,9 +26,9 @@ test('include start and end positions for comments', async () => {
 <iframe>Hello</iframe><div></div>`;
 	const { ast } = await parse(input);
 
-	const comment = ast.children[1];
+	const comment = ast.children[1] as ElementNode;
 	assert.is(comment.type, 'comment');
-	assert.ok(comment.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(comment.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(comment.position.end, 'Expected serialized output to contain an end position');
 });
 
@@ -39,20 +40,20 @@ test('include start and end positions for text', async () => {
 Hello world!`;
 	const { ast } = await parse(input);
 
-	const text = ast.children[1];
+	const text = ast.children[1] as ElementNode;
 	assert.is(text.type, 'text');
-	assert.ok(text.position.start, 'Expected serialized output to contain a start position');
-	assert.ok(text.position.end, 'Expected serialized output to contain an end position');
+	assert.ok(text.position?.start, 'Expected serialized output to contain a start position');
+	assert.ok(text.position?.end, 'Expected serialized output to contain an end position');
 });
 
 test('include start and end positions for self-closing tags', async () => {
 	const input = '<input/>';
 	const { ast } = await parse(input);
 
-	const element = ast.children[0];
+	const element = ast.children[0] as ElementNode;
 	assert.is(element.type, 'element');
 	assert.is(element.name, 'input');
-	assert.ok(element.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(element.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(element.position.end, 'Expected serialized output to contain an end position');
 });
 
@@ -62,9 +63,9 @@ test('include correct start and end position for self-closing tag', async () =>
 <li />`;
 	const { ast } = await parse(input);
 
-	const li = ast.children[1];
+	const li = ast.children[1] as ElementNode;
 	assert.is(li.name, 'li');
-	assert.ok(li.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(li.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(li.position.end, 'Expected serialized output to contain an end position');
 
 	assert.equal(
@@ -85,9 +86,9 @@ test('include correct start and end position for normal closing tag', async () =
 <li></li>`;
 	const { ast } = await parse(input);
 
-	const li = ast.children[1];
+	const li = ast.children[1] as ElementNode;
 	assert.is(li.name, 'li');
-	assert.ok(li.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(li.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(li.position.end, 'Expected serialized output to contain an end position');
 
 	assert.equal(
@@ -107,9 +108,9 @@ test('include start and end position if frontmatter is only thing in file (#802)
 ---`;
 	const { ast } = await parse(input);
 
-	const frontmatter = ast.children[0];
+	const frontmatter = ast.children[0] as FrontmatterNode;
 	assert.is(frontmatter.type, 'frontmatter');
-	assert.ok(frontmatter.position.start, 'Expected serialized output to contain a start position');
+	assert.ok(frontmatter.position?.start, 'Expected serialized output to contain a start position');
 	assert.ok(frontmatter.position.end, 'Expected serialized output to contain an end position');
 
 	assert.equal(
diff --git a/packages/compiler/test/parse/serialize.ts b/packages/compiler/test/parse/serialize.ts
index 98bbd5c2..2fe3dbeb 100644
--- a/packages/compiler/test/parse/serialize.ts
+++ b/packages/compiler/test/parse/serialize.ts
@@ -25,7 +25,7 @@ let content = "Testing 123";
 </Markdown>
 `;
 
-let result: TransformResult;
+let result: string;
 test.before(async () => {
 	const { ast } = await parse(FIXTURE);
 	try {
diff --git a/packages/compiler/test/stress/index.ts b/packages/compiler/test/stress/index.ts
index 783633a9..18600ab3 100644
--- a/packages/compiler/test/stress/index.ts
+++ b/packages/compiler/test/stress/index.ts
@@ -224,7 +224,7 @@ async function test() {
 }
 
 // Throttle the rendering a paths to prevents creating too many Promises on the microtask queue.
-function* throttle(max, tests) {
+function* throttle(max: number, tests: any) {
 	const tmp = [];
 	let i = 0;
 	for (const t of tests) {
diff --git a/packages/compiler/test/tsx-errors/eof.ts b/packages/compiler/test/tsx-errors/eof.ts
index 5e49583b..5a56a030 100644
--- a/packages/compiler/test/tsx-errors/eof.ts
+++ b/packages/compiler/test/tsx-errors/eof.ts
@@ -1,6 +1,7 @@
 import { convertToTSX } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { TSXResult } from '../../types.js';
 
 const FIXTURE = `<html>
   <head>
@@ -13,7 +14,7 @@ const FIXTURE = `<html>
   </body>
 </html>`;
 
-let result: TransformResult;
+let result: TSXResult;
 test.before(async () => {
 	result = await convertToTSX(FIXTURE, {
 		filename: '/src/components/EOF.astro',
diff --git a/packages/compiler/test/tsx-errors/fragment-shorthand.ts b/packages/compiler/test/tsx-errors/fragment-shorthand.ts
index 4833023c..d5744d09 100644
--- a/packages/compiler/test/tsx-errors/fragment-shorthand.ts
+++ b/packages/compiler/test/tsx-errors/fragment-shorthand.ts
@@ -1,6 +1,7 @@
 import { convertToTSX } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { TSXResult } from '../../types.js';
 
 const FIXTURE = `<html>
   <head>
@@ -11,7 +12,7 @@ const FIXTURE = `<html>
   </body>
 </html>`;
 
-let result: TransformResult;
+let result: TSXResult;
 test.before(async () => {
 	result = await convertToTSX(FIXTURE, {
 		filename: '/src/components/fragment.astro',
diff --git a/packages/compiler/test/tsx-errors/unfinished-component.ts b/packages/compiler/test/tsx-errors/unfinished-component.ts
index 6bc5cd37..a1c5162e 100644
--- a/packages/compiler/test/tsx-errors/unfinished-component.ts
+++ b/packages/compiler/test/tsx-errors/unfinished-component.ts
@@ -1,10 +1,11 @@
 import { convertToTSX } from '@astrojs/compiler';
 import { test } from 'uvu';
 import * as assert from 'uvu/assert';
+import type { TSXResult } from '../../types.js';
 
 const FIXTURE = '<div class={';
 
-let result: TransformResult;
+let result: TSXResult;
 test.before(async () => {
 	result = await convertToTSX(FIXTURE, {
 		filename: '/src/components/unfinished.astro',
diff --git a/packages/compiler/test/tsx-sourcemaps/tags.ts b/packages/compiler/test/tsx-sourcemaps/tags.ts
index 9eb33136..72e06872 100644
--- a/packages/compiler/test/tsx-sourcemaps/tags.ts
+++ b/packages/compiler/test/tsx-sourcemaps/tags.ts
@@ -19,7 +19,7 @@ test('tag close', async () => {
 test('tag with spaces', async () => {
 	const input = '<Button      ></Button>';
 	const { map } = await convertToTSX(input, { sourcemap: 'both', filename: 'index.astro' });
-	const tracer = new TraceMap(map);
+	const tracer = new TraceMap(map as any);
 
 	const generated = generatedPositionFor(tracer, { source: 'index.astro', line: 1, column: 14 });
 
diff --git a/packages/compiler/test/utils.ts b/packages/compiler/test/utils.ts
index 68f9bf76..f0061e4f 100644
--- a/packages/compiler/test/utils.ts
+++ b/packages/compiler/test/utils.ts
@@ -2,7 +2,7 @@ import { convertToTSX, transform } from '@astrojs/compiler';
 import { TraceMap, generatedPositionFor, originalPositionFor } from '@jridgewell/trace-mapping';
 import sass from 'sass';
 
-export async function preprocessStyle(value, attrs): Promise<any> {
+export async function preprocessStyle(value: any, attrs: any): Promise<any> {
 	if (!attrs.lang) {
 		return null;
 	}
@@ -48,7 +48,7 @@ export async function testTSXSourcemap(input: string, snippet: string) {
 	if (!snippetLoc) throw new Error(`Unable to find "${snippet}"`);
 
 	const { code, map } = await convertToTSX(input, { sourcemap: 'both', filename: 'index.astro' });
-	const tracer = new TraceMap(map);
+	const tracer = new TraceMap(map as any);
 
 	const generated = generatedPositionFor(tracer, {
 		source: 'index.astro',