Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join-base directive #665

Closed
wants to merge 2 commits into from
Closed

Add join-base directive #665

wants to merge 2 commits into from

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 8, 2022

Note that this is just an experiment and is not ready to be merged. If successful it will turn into an RFC.

Changes

  • Adds a new directive join-base that can be used on any element to join a path to your base configuration. For example:
<img join-base:src="/images/penguin.png" />

Will get transformed to this HTML assuming your base config is "/docs/":

<img src="/docs/images/penguin.png" />

Testing

  • Test case added

Docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

🦋 Changeset detected

Latest commit: ccbeb84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp
Copy link
Contributor Author

matthewp commented Dec 8, 2022

!preview join-base

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

 > [email protected] release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--join-base" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--join-base tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-join-base-20221208164627) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-join-base-20221208164627" 🦋 success packages published successfully: 🦋 @astrojs/[email protected] 🦋 Creating git tag... 🦋 New tag: @astrojs/[email protected]

@matthewp
Copy link
Contributor Author

This was an experiment we didn't go with.

@matthewp matthewp closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant