Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: HTML minification removes whitespace that should not be removed #815

Closed
wackbyte opened this issue Jul 3, 2023 · 1 comment · Fixed by #816
Closed

🐛 BUG: HTML minification removes whitespace that should not be removed #815

wackbyte opened this issue Jul 3, 2023 · 1 comment · Fixed by #816

Comments

@wackbyte
Copy link
Contributor

wackbyte commented Jul 3, 2023

What version of @astrojs/compiler are you using?

1.5.3

What package manager are you using?

pnpm

What operating system are you using?

Linux (NixOS)

Describe the Bug

Here's an example:

<p>
    A
    <span>B</span>
    C
</p>
Value of compressHTML Screenshot of result
false image
true image

The whitespace is not removed if "B" is also text. I have several more examples in the repo I provided.

Link to Minimal Reproducible Example

https://gitlab.com/wackbyte/astro-compress-html-removes-whitespace
@wackbyte wackbyte mentioned this issue Jul 3, 2023
Closed
1 task
@wackbyte
Copy link
Contributor Author

wackbyte commented Jul 4, 2023

It seems that #809 may be the cause of this.

@wackbyte wackbyte mentioned this issue Jul 4, 2023
Merged
@ematipico ematipico mentioned this issue Sep 11, 2023
Closed
1 task
@cdtut cdtut mentioned this issue Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve whitespace in text surrounded by newlines wackbyte/astro-compiler
1 participant
@wackbyte