Support for view transition directives #832
Merged
+103
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 49eea26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
reviewed
Jul 18, 2023
bluwy
approved these changes
Jul 19, 2023
internal/printer/printer.go
Outdated
| @@ -141,6 +147,10 @@ func (p *printer) printCSSImports(cssLen int) { | |||
| p.print(fmt.Sprintf("import \"%s?astro&type=style&index=%v&lang.css\";", p.opts.Filename, i)) | |||
| i++ | |||
| } | |||
| if p.needsTransitionCSS { | |||
| p.addNilSourceMapping() | |||
| p.print(`import "astro/components/viewtransitions.css";`) | |||
There was a problem hiding this comment.
I didn't clearly comment this yesterday, I was also wondering if we should create a new option for this import path, similar to how we have the internalURL option.
Not blocking as this is experimental and we can change again if we want.
There was a problem hiding this comment.
Ah yeah, I can add that, good call.
There was a problem hiding this comment.
Awesome. Do we also want to prefix with "experimental"? (just in case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
transition:animateon an element is turned intodata-astro-transition-scope={renderTransition()}which is used to create a scope name for the particular element and set up the CSS.Testing
Docs
N/A