Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Unbalanced quotes in HTML attributes crashes compiler when parsing AST #904

Closed
Princesseuh opened this issue Dec 11, 2023 · 0 comments · Fixed by #923
Closed

🐛 BUG: Unbalanced quotes in HTML attributes crashes compiler when parsing AST #904

Princesseuh opened this issue Dec 11, 2023 · 0 comments · Fixed by #923
Assignees
@MoustaphaDev
Labels
- P4: important Violate documented behavior or significantly improves performance (priority) feat: ast Related to the JSON AST output (scope)

Comments

@Princesseuh
Copy link
Member

What version of @astrojs/compiler are you using?

^2.2.2

What package manager are you using?

pnpm

What operating system are you using?

macOS

Describe the Bug

The following code: <main id="gotcha /> crashes the compiler due to the missing end quote.

For more details, see the following issue: withastro/language-tools#623

Link to Minimal Reproducible Example

See description
@Princesseuh Princesseuh added - P4: important Violate documented behavior or significantly improves performance (priority) feat: ast Related to the JSON AST output (scope) labels Dec 11, 2023
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 11, 2023
@Princesseuh Princesseuh removed the needs triage Issue needs to be triaged label Dec 12, 2023
@MoustaphaDev MoustaphaDev self-assigned this Dec 20, 2023
@MoustaphaDev MoustaphaDev mentioned this issue Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoustaphaDev MoustaphaDev

Labels
- P4: important Violate documented behavior or significantly improves performance (priority) feat: ast Related to the JSON AST output (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tokenizer): handle unterminated quoted attributes gracefully withastro/compiler
2 participants
@Princesseuh @MoustaphaDev