Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): create reference/legacy-flags.mdx #10467

Conversation

ArmandPhilippot
Copy link
Member

Description (required)

Translates in French the file reference/legacy-flags.mdx added in #9240

Note

In French, I don't think we use drapeaux for flags in this context so I hesitated between indicateurs and options. I think the last one is more commonly used and this matches the term we use in CLI reference.

Related issues & labels (optional)

  • Suggested label: i18n

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a56e179
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6765c9e688a8ad0008497184
😎 Deploy Preview https://deploy-preview-10467--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 19, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/reference/legacy-flags.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@thomasbnt
Copy link
Member

In French, I don't think we use drapeaux for flags in this context so I hesitated between indicateurs and options. I think the last one is more commonly used and this matches the term we use in CLI reference.

I used flags in french in #10469. 👍

@ArmandPhilippot
Copy link
Member Author

ArmandPhilippot commented Dec 19, 2024

I used flags in french in #10469. 👍

I'd say we should be consistent across the docs to avoid confusing the reader. So I think we should agree on a single term...
I checked on Starlight docs and I see option is also used in two places (https://starlight.astro.build/fr/manual-setup/#configurer-les-collections-de-contenu and https://starlight.astro.build/fr/reference/overrides/#id) where flag is used in the VO. And it's also what we have in CLI reference for Common flags.
But also have other pages in Astro Docs that uses drapeau and indicateur (some integrations and upgrade guides for example) ... But I don't see any flag in Algolia search (in the VF I mean).

@thomasbnt
Copy link
Member

I think, flagsmakes it easier for developers to understand, and even in French. 👍

Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ArmandPhilippot
Copy link
Member Author

I think, flagsmakes it easier for developers to understand, and even in French. 👍

I never saw flag in a French documentation (but I have to say that I don't read much documentation in French so... 😅 ). I'm not sure it has more meaning for French people... I checked what other docs are using for flag:

So I'd say we should translate it... but maybe option is not the best translation? I don't know...

@thomasbnt
Copy link
Member

I think, flagsmakes it easier for developers to understand, and even in French. 👍

I never saw flag in a French documentation (but I have to say that I don't read much documentation in French so... 😅 ). I'm not sure it has more meaning for French people... I checked what other docs are using for flag:

So I'd say we should translate it... but maybe option is not the best translation? I don't know...

Owh so much words for this one.. we can change it for option 👍🏼

@ArmandPhilippot
Copy link
Member Author

Yeah... 😅
In the CLI context, we also have PHP that uses option in French for flag. In other contexts, they also use option and drapeau.
Nobody knows how to translate it... 😆

IMO, option is the most significant term in both contexts (option de ligne de commande, option de configuration...).

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@yanthomasdev yanthomasdev merged commit bbceac8 into withastro:main Dec 20, 2024
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-create-reference/legacy-flags.mdx branch December 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants