Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on-demand-rendering.mdx #9552

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

JusticeMatthew
Copy link
Contributor

Description (required)

Updates on-demand-rendering.mdx to match the changes from PR #9527

Related issues & labels (optional)

  • Suggested label: code snippet update

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9beabc
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66fee7b7d49d8d00086128e6
😎 Deploy Preview https://deploy-preview-9552--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918
Copy link
Member

Thanks @JusticeMatthew ! Can you also update the line highlighting in this code sample? It was spotted in the other PR that now that this code sample is longer, I think it's no longer line 11 that should be highlighted!

@JusticeMatthew
Copy link
Contributor Author

TIL: That's how those lines are highlighted!

I had only looked at the GitHub preview and not the deploy preview which did not even show the highlights 😅

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much!

@sarah11918 sarah11918 merged commit afc9555 into withastro:5.0.0-beta Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants