Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Implement integration tests for the system #34

Open
6 tasks
apbendi opened this issue Oct 3, 2024 · 0 comments
Open
6 tasks

Re-Implement integration tests for the system #34

apbendi opened this issue Oct 3, 2024 · 0 comments
Labels
todo Issues that need to be tackled pre-audit

Comments

@apbendi
Copy link
Collaborator

apbendi commented Oct 3, 2024

  • UniStaker integration tests were broken and removed by the modifications made, we should reintroduce integration tests again
  • Broadly speaking there are two kinds of integration tests we can write
    • Implementation specific unit tests that fork from real chain state for a specific DAO: e.g. ARB/Arbitrum specific testing
    • Tests that exercise the full system end to end locally without mocks or fakes, but not using a concrete instance onchain
  • Ideally, we might find a way to abstract the integration tests such that they could be run in both of the aforementioned contexts
    • Inherit from an abstract test suite, implement a few methods, including setUp, and then the test suite will run agains that scenario. This could be used for a locally set up version, for Arb specifically in fork tests, but also (in theory) for other concrete DAO instances in the future
@apbendi apbendi mentioned this issue Oct 3, 2024
4 tasks
@apbendi apbendi added the todo Issues that need to be tackled pre-audit label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Issues that need to be tackled pre-audit
Projects
None yet
Development

No branches or pull requests

1 participant