Change the STAKE_TOKEN to be a simple IERC20 in GovernanceStaker instead of IERC20Delegates

[alexkeating]

No description provided.

[alexkeating]

@apbendi Some things I am noticing after starting the implementation the permit functionality relies on this so should I spin that out into an extension? And the delegation surrogate relies on this so should I spin that functionality to another extension like GovernanceStakingVotes?

[apbendi]

Hey @alexkeating, yes that is captured in #31 in the bullet point that says:

Move the permitAndStake and permitAndStakeMore methods into an (optional) extension (not all governance tokens will have permit methods)

So we definitely need to do this, but it needs to be sequenced/stacked appropriately in line with the generalization work.

[alexkeating]

Cool, going to drop then as I didn't realize the todos in the issue were so dependent.

[apbendi]

Adding this comment as a reminder to tackle what's handled in this comment here.

Since we're going to change STAKE_TOKEN to a normal IERC20 in the base staker contract, we'll have to cast it to an IERC20Permit which we import from OZ here. Part of me wonders if we should do more than that to ensure that the STAKE_TOKEN provided at construction is an IERC20Permit