String consturctor causing ESP to crash?

[witnessmenow]

As mentioned in #34, need to investigate

[dmadison]

There's two reasons for this.

First is that the String is stored in a temporary buffer in the constructor. This temporary buffer is then passed to the char* constructor which stores the address for later reference. Once the function exits the buffer no longer exists and the memory address is invalid. You can try this by assigning _apiKey directly in the String constructor.

Second is that the constructor call is not delegated, so this line creates a new YoutubeApi object and then immediately throws it away instead of modifying the current object.

I'll push a tentative working fix to the branch, but we should discuss some of the alternatives in the PR.