Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protractorAdapter: $ is broken - alway throws NoElementWithLocatorError #66

Open
hepiyellow opened this issue Apr 2, 2019 · 0 comments
Assignees
Labels
bug Something isn't working Proprity:High

Comments

@hepiyellow
Copy link
Contributor

The bug is here:

if (!elGetters.length) {

elGetters is actually a Protractor ElementArrayFinder.
Which doesn't have a length property.
We should use count().

Why we haven't noticed this

  • There are no tests for protractor adapter
  • Protractor type for ElementArrayFinder allows any keys using:
       [key: string]: any;
    
@hepiyellow hepiyellow added bug Something isn't working Proprity:High labels Apr 2, 2019
@hepiyellow hepiyellow self-assigned this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Proprity:High
Projects
None yet
Development

No branches or pull requests

1 participant